Skip to content

feat: comment and alter column support #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

zhamlin
Copy link
Contributor

@zhamlin zhamlin commented Dec 14, 2021

No description provided.

@alamb
Copy link
Contributor

alamb commented Dec 14, 2021

Thank you @zhamlin -- this PR appears to have a conflict that need to be resolved

@zhamlin zhamlin force-pushed the feat/comment-and-alter-column branch from f4ce662 to 0c35726 Compare December 14, 2021 23:11
@coveralls
Copy link

coveralls commented Dec 15, 2021

Pull Request Test Coverage Report for Build 1580322714

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 142 of 150 (94.67%) changed or added relevant lines in 5 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/ddl.rs 15 16 93.75%
src/parser.rs 41 44 93.18%
src/ast/mod.rs 10 14 71.43%
Files with Coverage Reduction New Missed Lines %
src/ast/ddl.rs 1 82.19%
src/ast/mod.rs 24 75.72%
Totals Coverage Status
Change from base Build 1579702740: 0.1%
Covered Lines: 6584
Relevant Lines: 7305

💛 - Coveralls

@zhamlin zhamlin force-pushed the feat/comment-and-alter-column branch from 0c35726 to 2a3801c Compare December 15, 2021 14:48
@alamb alamb merged commit 9569d1b into apache:main Dec 17, 2021
@alamb
Copy link
Contributor

alamb commented Dec 17, 2021

Thanks again @zhamlin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants