support for session transaction and transaction snapshot. #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: poonai <[email protected]>
Signed-off-by: poonai <[email protected]>
alamb
approved these changes
Dec 13, 2021
tests/sqlparser_common.rs
Outdated
| @@ -3586,7 +3586,7 @@ fn parse_set_transaction() { | |||
| // TRANSACTION, so no need to duplicate the tests here. We just do a quick | |||
| // sanity check. | |||
| match verified_stmt("SET TRANSACTION READ ONLY, READ WRITE, ISOLATION LEVEL SERIALIZABLE") { | |||
| Statement::SetTransaction { modes } => assert_eq!( | |||
| Statement::SetTransaction { modes, .. } => assert_eq!( | |||
There was a problem hiding this comment.
I think it would be valuable to validate the contents of session and mode here
Pull Request Test Coverage Report for Build 1579647958Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@poonai looks like this PR needs to have |
Signed-off-by: poonai <[email protected]>
|
@alamb done and thanks for the project. :) |
alamb
approved these changes
Dec 14, 2021
🙇 thank you -- I am but a caretaker of the giants that came before me (@andygrove and @nickolay, @Dandandan and @benesch largely) |
|
I pushed ce23ba0 to get the CI to run cleanly |
|
Thanks again @poonai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for snapshot and session-wide transactions as per
https://www.postgresql.org/docs/9.3/sql-set-transaction.html