fix: mysql backslash escaping #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1613258541Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
alamb
reviewed
Dec 8, 2021
There was a problem hiding this comment.
Thank you for the contribution @vasilev-alex ! This PR looks close
vasilev-alex
force-pushed
the
mysql-backslash-escaping
branch
from
e212004 to
0be2f3a
Compare
vasilev-alex
force-pushed
the
mysql-backslash-escaping
branch
from
018a4e7 to
8b04b40
Compare
alamb
approved these changes
Dec 23, 2021
| @@ -176,19 +178,36 @@ fn parse_quote_identifiers() { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_unterminated_escape() { | |||
| let sql = r#"SELECT 'I\'m not fine\'"#; | |||
| let expr = expr_from_projection(only(&value.projection)); | ||
| assert_eq!( | ||
| *expr, | ||
| Expr::Value(Value::SingleQuotedString("I'm fine".to_string())) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue #362
Works only when a raw string provided as input