Skip to content

Move Statement and Expr so they hold identifiable structs #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

tvallotton
Copy link
Contributor

This is of course a major breaking change. But I think it's worth considering. I also fixed the DROP CONSTRAINT thing I mentioned in #342.

@tvallotton tvallotton changed the title Move Statement and Expr so they hold identifiable structs Move Statement and Expr so they hold identifiable structs Sep 4, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @tvallotton 👍

In general, I don't feel qualified to approve / accept this level of change without some additional buy in from @nickolay / @andygrove / @Dandandan . #311 (comment) seems like a good usecase to me but it is a pretty major change for all users of sqlparser-rs.

I view myself as a caretaker now and feel good about merging and releasing "round out the SQL support" type PRs. Splitting out the changes to ALTER TABLE as a separate PR, for example, would be fine,

@@ -0,0 +1,4 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file looks pretty specific to your own environment -- did you mean to propose including it into this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah I think I was a little careless as I initially didn't think I was going to submit a pull request. I also noticed I made the changes on the master branch, would you prefer I did another submission on a separate branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed I made the changes on the master branch,

I don't think it matters what branch you work on in your fork (tvallotton:main is fine)

@@ -1,3 +1,6 @@
# Fork
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably not accurate

@alamb
Copy link
Contributor

alamb commented Sep 9, 2021

See also #311

@alamb
Copy link
Contributor

alamb commented Dec 8, 2021

Closing old seemingly stalled PR. Please re-open if this was a mistake

@alamb
Copy link
Contributor

alamb commented Feb 8, 2022

Sadly I don't have the time to help drive projects such as this. Unless one of the other maintainers wants to do so, PRs like this are not likely to be merged. I am sorry I don't have the time and I am sorry if your time was wasted.

As the current state of affairs might not have been clear in the project's README. I have added #416 to try and help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants