Skip to content

Fix deprecated way of initializing SimpleLogger #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2020
Merged

Fix deprecated way of initializing SimpleLogger #275

merged 3 commits into from
Sep 7, 2020

Conversation

Dandandan
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 242631934

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.912%
Totals Coverage Status
Change from base Build 242284717: 0.0%
Covered Lines: 4591
Relevant Lines: 4995
💛 - Coveralls

@Dandandan Dandandan merged commit 2f71324 into main Sep 7, 2020
@nickolay
Copy link
Contributor

Thanks Daniël!

@nickolay nickolay deleted the fix_linting branch September 26, 2020 23:53
nickolay added a commit to nickolay/sqlparser-rs that referenced this pull request Oct 5, 2020
@nickolay
Follow-up to apache#275: Bump simple_logger version in Cargo.toml
7dc5d4c 
SimpleLogger is private in v1.6. Bumping its version in Cargo.toml makes
`git pull && carg test` use the new version in an existing checkout
(with an existing Cargo.lock file referencing the old version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dandandan @coveralls @nickolay