Skip to content

consume semi colon at the end of select and delete queries #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2018
Merged

consume semi colon at the end of select and delete queries #27

merged 2 commits into from
Oct 17, 2018

Conversation

virattara
Copy link
Contributor

No description provided.

@virattara virattara mentioned this pull request Oct 16, 2018
Merged
@andygrove
Copy link
Member

@virattara Could you add a unit test for this please

@virattara virattara force-pushed the fix_select_semi_colon branch from 3f4c5c8 to 2cbacf3 Compare October 17, 2018 10:24
@virattara virattara force-pushed the fix_select_semi_colon branch from 2cbacf3 to 9898e99 Compare October 17, 2018 10:25
@virattara
Copy link
Contributor Author

@andygrove Done.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 72

  • 19 of 21 (90.48%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.262%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_generic.rs 17 19 89.47%
Totals Coverage Status
Change from base Build 71: 0.0%
Covered Lines: 2164
Relevant Lines: 2663
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 73

  • 19 of 21 (90.48%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.262%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_generic.rs 17 19 89.47%
Totals Coverage Status
Change from base Build 71: 0.0%
Covered Lines: 2164
Relevant Lines: 2663
💛 - Coveralls

@andygrove andygrove merged commit face972 into apache:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@virattara @andygrove @coveralls