Skip to content

[snowflake] Support single line comments starting with '#' or '//' #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

eyalleshem
Copy link
Contributor

Add support for that in the snowflake dialect

@eyalleshem eyalleshem changed the title Snowflake db supports signle line comments that starts with '#' or '/' , Ad support to snowflake-db single line comments that starts with '#' or '/' , Aug 16, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 210775918

  • 52 of 54 (96.3%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.995%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tokenizer.rs 27 29 93.1%
Totals Coverage Status
Change from base Build 205645794: 0.05%
Covered Lines: 4597
Relevant Lines: 4997

💛 - Coveralls

@nickolay nickolay changed the title Ad support to snowflake-db single line comments that starts with '#' or '/' , [snowflake] Support single line comments starting with '#' or '//' Sep 7, 2020
@nickolay nickolay merged commit 1c6077c into apache:main Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants