-
Notifications
You must be signed in to change notification settings - Fork 605
Support AUTO_INCREMENT for MySQL and AUTOINCREMENT for SQLite #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 186220604
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. 👍
@nickolay does this seem okay to you?
Yes, looks good to me too, but please add a note about this being MySQL-specific as a comment in the code (better in all of: AST, the parser and the tests), as:
Documenting the differences between dialects like this should be useful both for our users and for designing a better solution for the dialects problem.
|
Thank you for your suggestions. I find SQLite support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In MySQL it's AUTO_INCREMENT
(see https://dev.mysql.com/doc/refman/8.0/en/create-table.html)
and in SQLite it's AUTOINCREMENT.
We use
ColumnOption::DialectSpecific(Vec<Token>)
to avoid adding a new variant for each vendor-specific column option.