Skip to content

Implement parsing insert statement #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2018
Merged

Implement parsing insert statement #21

merged 3 commits into from
Sep 29, 2018

Conversation

ivanceras
Copy link
Contributor

@ivanceras ivanceras commented Sep 21, 2018 •
edited
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Sep 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 40

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.007%) to 81.962%
Files with Coverage Reduction New Missed Lines %
sqlparser.rs 81 84.76%
Totals Coverage Status
Change from base Build 38: 2.007%
Covered Lines: 827
Relevant Lines: 1009
💛 - Coveralls

@ivanceras ivanceras mentioned this pull request Sep 21, 2018
Closed
ghost
ghost approved these changes Sep 29, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@andygrove andygrove merged commit e6ad7ab into apache:master Sep 29, 2018
jmhain pushed a commit to jmhain/sqlparser-rs that referenced this pull request Jul 14, 2024
@HiranmayaGundu
fix: have wildcard replace work in duckdb and snowflake syntax (apach…
16cdc92 
…e#21)

This address https://sigmacomputing.atlassian.net/browse/SIG-52729.

The syntax that broke was `SELECT * REPLACE() from table`. The
functionality already existed, needed to be enabled for Snowflake and
DuckDB.

I added test cases so that the examples given in the respective
documentation passed:
duck db: https://duckdb.org/docs/sql/query_syntax/select.html
snowflake: https://docs.snowflake.com/en/sql-reference/sql/select
jmhain added a commit to jmhain/sqlparser-rs that referenced this pull request Jul 14, 2024
@jmhain
Revert "fix: have wildcard replace work in duckdb and snowflake syntax (
769a6cf 
apache#21)"

This reverts commit 16cdc92, reversing
changes made to b22099b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanceras @coveralls @andygrove