-
Notifications
You must be signed in to change notification settings - Fork 605
Add CREATE TABLE AS support #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 144885262
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added my thoughts inline.. Of those I'd like query.is_none()
to be fixed before merging, for the rest I'm curious what you think.
Add a test for CTAS with schema and note it's bigquery-only Add a constraints-only schema and note it's postgresql-only Simplify the parse_create_table_if_not_exists test to focus on `IF NOT EXISTS` parsing
I just realized that I also wanted to have a test for that and for I think this is ready to be merged, what do you think? |
I think so too! Thanks a lot :) |
Excellent, thanks! I summarized the changes here in the commit message as follows:
|
Issue: https://github.com/andygrove/sqlparser-rs/issues/205