-
Notifications
You must be signed in to change notification settings - Fork 606
implement alter table for sqlite grammar #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 137608205
💛 - Coveralls |
56567f8
to
31894a3
Compare
Hey @mz, thanks for the PR! Please let me know when this is ready for review, as I see you're still working on it. |
Hi @nickolay I'm working on the test coverage, I have already covered alter table test, but it still says that coverage decreased, can you help me to see what's wrong. |
The coverage is somewhat flaky unfortunately. Given that in this case it thinks that an existing line lost coverage, whereas it wasn't covered in the first place, I think it's not worth worrying about:
|
Thanks, @nickolay , It's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a couple of renames and merging this now.
implement alter table for SQLite grammar:https://www.sqlite.org/lang_altertable.html