Skip to content

implement alter table for sqlite grammar #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2020

Conversation

miuy56dc
Copy link
Contributor

implement alter table for SQLite grammar:https://www.sqlite.org/lang_altertable.html

@coveralls
Copy link

coveralls commented Jun 16, 2020

Pull Request Test Coverage Report for Build 137608205

  • 62 of 66 (93.94%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 91.821%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 28 29 96.55%
src/ast/ddl.rs 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
src/ast/ddl.rs 1 85.0%
Totals Coverage Status
Change from base Build 134288244: 0.02%
Covered Lines: 4120
Relevant Lines: 4487

💛 - Coveralls

@miuy56dc miuy56dc force-pushed the add_alter_stmt branch 6 times, most recently from 56567f8 to 31894a3 Compare June 16, 2020 12:41
@nickolay
Copy link
Contributor

Hey @mz, thanks for the PR! Please let me know when this is ready for review, as I see you're still working on it.

@miuy56dc
Copy link
Contributor Author

Hi @nickolay I'm working on the test coverage, I have already covered alter table test, but it still says that coverage decreased, can you help me to see what's wrong.

@nickolay
Copy link
Contributor

The coverage is somewhat flaky unfortunately. Given that in this case it thinks that an existing line lost coverage, whereas it wasn't covered in the first place, I think it's not worth worrying about:

AlterTableOperation::DropConstraint { name } => write!(f, "DROP CONSTRAINT {}", name),

@miuy56dc
Copy link
Contributor Author

The coverage is somewhat flaky unfortunately

Thanks, @nickolay , It's ready for review.

@mz
Copy link

mz commented Jun 16, 2020

Hey @mz, thanks for the PR! Please let me know when this is ready for review, as I see you're still working on it.

Hey, I'm @mz and he is @mashuai :-) but nice to meet you both anyway !

@miuy56dc miuy56dc requested a review from nickolay June 16, 2020 15:31
Copy link
Contributor

@nickolay nickolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a couple of renames and merging this now.

@nickolay nickolay merged commit faeb7d4 into apache:master Jun 16, 2020
nickolay pushed a commit that referenced this pull request Jul 31, 2020
This is a follow-up to #203
where ALTER TABLE ADD COLUMN support was initially implemented.

Fixes #233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants