-
Notifications
You must be signed in to change notification settings - Fork 612
Add benchmarks using cargo bench / criterion #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! (This fixes #188.) As I feared, this slows down the clean build (e.g. rust-lang/cargo#1596 (comment) describes a possible solution, would you be willing to do that? Alternatively we could keep this on a branch of its own and include instructions on cherry-picking it in the README on |
That would be a nice solution. I'll be looking into that! |
I moved them to |
Awesome, thank you! |
@@ -0,0 +1,7 @@ | |||
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intended to be committed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, is the result of running cargo new --lib
, didn't notice that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maxcountryman! I removed this file from master.
- Update CHANGELOG - Update `.gitignore` for the build directory of the benchmark crate - Remove src/lib from the recently added benchmark crate per https://github.com/andygrove/sqlparser-rs/pull/190#pullrequestreview-425835379
Adds two simple benchmarks, using
cargo bench
andcriterion
.On my machine: