Skip to content

Add support for MySQL's STRAIGHT_JOIN join operator. #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

romanb
Copy link
Contributor

@romanb romanb commented Apr 9, 2025

This PR adds support for parsing the MySQL STRAIGHT_JOIN join operator.

See https://dev.mysql.com/doc/refman/8.4/en/join.html for reference.

@@ -2197,6 +2200,8 @@ pub enum JoinOperator {
match_condition: Expr,
constraint: JoinConstraint,
},
/// STRAIGHT_JOIN (non-standard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we include a link to the mysql docs for reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, done!

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @romanb!
cc @alamb

@iffyio iffyio merged commit 67c3be0 into apache:main Apr 10, 2025
9 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants