Add support for parenthesized subquery as IN predicate
#1793
+22
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Apr 2, 2025
adamchainz
force-pushed
the
postgresql_in_set_expression
branch
from
58372cf to
a2d59d6
Compare
adamchainz
changed the title
adamchainz
commented
Apr 4, 2025
src/parser/mod.rs
Outdated
| let in_op = if self.parse_keyword(Keyword::SELECT) || self.parse_keyword(Keyword::WITH) { | ||
| self.prev_token(); | ||
| Expr::InSubquery { | ||
| let in_op = match self.try_parse(|p| p.parse_query_body(p.dialect.prec_unknown())) { |
There was a problem hiding this comment.
The previous approach peeked for a SELECT or WITH, but we cannot rely on that because there may be more than one parenthesis, as in IN ((SELECT ...) UNION ()).
The new approach tries to parse a subquery first, then an in list second.
| } | ||
|
|
||
| #[test] | ||
| fn parse_in_union() { |
There was a problem hiding this comment.
I only added one test - happy to add more if deemed necessary.
iffyio
reviewed
Apr 5, 2025
There was a problem hiding this comment.
Thanks @adamchainz! This looks good to me overall, left one comment
src/parser/mod.rs
Outdated
| let in_op = if self.parse_keyword(Keyword::SELECT) || self.parse_keyword(Keyword::WITH) { | ||
| self.prev_token(); | ||
| Expr::InSubquery { | ||
| let in_op = match self.try_parse(|p| p.parse_query_body(p.dialect.prec_unknown())) { |
|
Marking as draft in the meantime as this is no longer pending review, @adamchainz please feel free to undraft and ping when ready! |
adamchainz
force-pushed
the
postgresql_in_set_expression
branch
from
a2d59d6 to
feac964
Compare
iffyio
changed the title
IN predicate
iffyio
approved these changes
Apr 15, 2025
|
Yay, thank you! |
|
The code train keeps on moving in this repo. very impressive |
|
choo choo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1792.
This is my attempt to hack in support with my minimal Rust skills. I stopped when I realized that my change of
InSubqueryto useSetExprfor its subquery broke many tests.