Skip to content

Snowflake: Support dollar quoted comments #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2025

Conversation

7phs
Copy link
Contributor

@7phs 7phs commented Mar 4, 2025

Snowflake supports dollar-quoted comments as string literals when creating tables, views, and their fields.

For example:

CREATE OR REPLACE TEMPORARY VIEW foo.bar.baz (
    "COL_1" COMMENT $$comment 1$$
) COMMENT = $$view comment$$ AS (
    SELECT 1
)

This pull request adds support for this type of comments.

@7phs 7phs changed the title Snowflake: Support dollar quoted comment of table, view and field Snowflake: Support dollar quoted comment when creating tables, views, and their fields Mar 4, 2025
@7phs 7phs requested a review from iffyio March 13, 2025 17:49
@7phs 7phs requested a review from iffyio March 14, 2025 16:18
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @7phs!
cc @alamb

@iffyio iffyio changed the title Snowflake: Support dollar quoted comment when creating tables, views, and their fields Snowflake: Support dollar quoted comments Mar 15, 2025
@iffyio iffyio merged commit 10cf7c1 into apache:main Mar 15, 2025
9 checks passed
@iffyio iffyio deleted the snowflake_dollar_quoted_comment branch March 15, 2025 06:07
@alamb
Copy link
Contributor

alamb commented Mar 16, 2025

🚀

ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants