Skip to content

Align SQL formatting and add all missing table options #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

benrsatori
Copy link
Contributor

No description provided.

@benrsatori benrsatori closed this Feb 26, 2025
@mvzink
Copy link
Contributor

mvzink commented Feb 26, 2025

If you are considering overhauling and fleshing out support for table options, I would be strongly in favor of making them work like column options: i.e. a Vec of options that can be parsed and rendered in any order. See Parser::parse_optional_column_option and its various usages. It would also be easier to have parity with CREATE TABLE and ALTER TABLE that way (both could just include a Vec<TableOption> or whatever).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants