BigQuery: Add support for CREATE SCHEMA options
#1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
changed the title
CREATE SCHEMA optionsCREATE SCHEMA options
iffyio
force-pushed
the
bq-schema-options
branch
from
426b151 to
64ef5ab
Compare
alamb
approved these changes
Mar 13, 2025
alamb
reviewed
Mar 13, 2025
tests/sqlparser_postgres.rs
Outdated
| @@ -988,6 +988,7 @@ fn parse_create_schema_if_not_exists() { | |||
| Statement::CreateSchema { | |||
| if_not_exists: true, | |||
| schema_name, | |||
| .. | |||
There was a problem hiding this comment.
I personally think adding explicit ignores here
Suggested change
| .. | |
| options: _, | |
| default_collate_spec: _, |
Is better as then if a new field is added then the compiler will point out this place as needing to be checked
That being said, I don't think it is critical in this case
```sql CREATE SCHEMA DEFAULT COLLATE 'foo' myschema OPTIONS(key='value'); ``` [BigQuery](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#create_schema_statement)
iffyio
force-pushed
the
bq-schema-options
branch
from
64ef5ab to
3cd2a47
Compare
|
🚀 |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery