Treat COLLATE like any other column option #1731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows preserving the orderings of column options. We also no longer hardcode a list of dialects which accept a column collation, as it's part of the SQL standard and some dialects which do support it were missing from the list.
mvzink
force-pushed
the
push-nkpmkvkurnuw
branch
from
39c5e00 to
7f101b2
Compare
This was referenced Mar 8, 2025
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows preserving the orderings of column options.
We also no longer hardcode a list of dialects which accept a column collation, as it's part of the SQL standard and some dialects which do support it were missing from the list (e.g. MSSQL).