Skip to content

Add support for MS Varbinary(MAX) (#1714) #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

TylerBrinks
Copy link
Contributor

Hi, I'm the maintainer of https://github.com/TylerBrinks/SqlParser-cs, a C# port of this library. I'm finally getting around to submitting my first PR for this library based on an issue raised in the C# project.

This change updates the Varbinary type to take a BinaryLength similar to Varchar and Nvarchar where IntegerLength and Max is added to the enum. This replaces the u64 parameter in order to allow both varbinary(50) and varbinary(max) syntas for MS Sql and Generic implementations.

@alamb
Copy link
Contributor

alamb commented Feb 7, 2025

a C# port of this library.

Very cool!

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TylerBrinks -- this looks good to me. It seems there is a CI failure but the code looks good 👍

Once the CI is fixed I think we can merge it

@TylerBrinks
Copy link
Contributor Author

I think I got it right in the updated most recent push. Awaiting approval if it passes the criteria.

@TylerBrinks
Copy link
Contributor Author

@alamb Anything else I need to address? I'm learning the standard Rust way of doing things, hoping I got it right based on the PR checks in place.

@alamb
Copy link
Contributor

alamb commented Feb 13, 2025

@alamb Anything else I need to address? I'm learning the standard Rust way of doing things, hoping I got it right based on the PR checks in place.

Nope -- sorry for the delay and thanks for the pink @TylerBrinks -- I just lost track of this PR

I gave it another look and it looks great to me ❤️

🚀

@alamb alamb merged commit a5bbb5e into apache:main Feb 13, 2025
9 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants