-
Notifications
You must be signed in to change notification settings - Fork 602
Add suppport for Show Objects statement for the Snowflake parser #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iffyio
merged 14 commits into
apache:main
from
Embucket:DanCodedThis/show-objects-statement
Feb 6, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8083bd2
Added ShowObjects statement
DanCodedThis 1d71037
Parsing, next tests
DanCodedThis e745fb2
Small comment
DanCodedThis c0f4f3c
Tests done according to other SHOW statements
DanCodedThis 01615ef
Removed unnecessary comments
DanCodedThis e13a1b8
Fix test in other that object cases. Cargo fmt.
Vedin 7768f6f
Update src/parser/mod.rs
DanCodedThis dd4d972
Should fix the defer to generic dialect
DanCodedThis 0a4fcd2
Suggested done
DanCodedThis 0903a27
Merge branch 'main' into DanCodedThis/show-objects-statement
DanCodedThis bb86d89
import github fail
DanCodedThis b7bcc3b
Added `TERSE` in other snowflake tests, just in case
DanCodedThis 1812ace
no unwraps
DanCodedThis 6f562d8
cargo fmt
DanCodedThis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -588,6 +588,7 @@ define_keywords!( | |
NUMERIC, | ||
NVARCHAR, | ||
OBJECT, | ||
OBJECTS, | ||
OCCURRENCES_REGEX, | ||
OCTETS, | ||
OCTET_LENGTH, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this introduces a new node in the AST, can we add an assertion for one of these test cases covering that the AST looks like what is expected? i.e a test in this syle