Do not parse ASOF and MATCH_CONDITION as table factor aliases #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
approved these changes
Feb 1, 2025
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Vedin
added a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
…apache#1698)" This reverts commit 5f4be68.
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example 1 -
SELECT * FROM tbl ASOFASOFis parsed as the alias fortbl, but on Snowflake, it's reserved for theASOF JOINoption.Example 2 -
SELECT * FROM tbl1 ASOF JOIN tbl2 MATCH_CONDITION(...)MATCH_CONDITIONis parsed as the alias fortbl2, but on Snowflake, it's reserved for theASOF JOINoption.Added
ASOFANDMATCH_CONDITIONas reserved keywords for table alias and added a test for the ASOF JOIN functionality without explicit aliases.