Add parsing for GRANT ROLE and GRANT DATABASE ROLE in Snowflake dialect #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Feb 3, 2025
src/ast/mod.rs
Outdated
| @@ -5912,6 +5924,7 @@ impl fmt::Display for GrantObjects { | |||
| display_comma_separated(schemas) | |||
| ) | |||
| } | |||
| GrantObjects::None => Ok(()), | |||
There was a problem hiding this comment.
Can we instead make GrantObjects optional at the usage sites that require it? i.e. objects: Option<GrantObjects>. Thinking so that we get the None representation by convention
There was a problem hiding this comment.
Good suggestion, fixed in the last commit
yoavcloud
force-pushed
the
sf_grant_role_dbrole
branch
from
41b29fb to
376dffc
Compare
iffyio
approved these changes
Feb 3, 2025
|
Rolling along ☸️ |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.