Add support for mysql table hints #1675
Merged
+266
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavcloud
reviewed
Jan 22, 2025
yoavcloud
reviewed
Jan 22, 2025
|
@AvivDavid-Satori left some minor comments, otherwise looks good. |
iffyio
reviewed
Jan 22, 2025
iffyio
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Thanks @AvivDavid-Satori! The changes look reasonable to me overall, left a couple comments regarding the test setup
iffyio
approved these changes
Jan 26, 2025
|
@AvivDavid-Satori could you merge in latest main? There's since been some api changes to |
AvivDavid-Satori
force-pushed
the
mysql-index-hints
branch
from
d173ced to
3256813
Compare
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
Vedin
added a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
This reverts commit e49bc18.
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.