Redshift: Fix parsing for quoted numbered columns #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombsimon
reviewed
Dec 3, 2024
added 2 commits
December 3, 2024 15:07
bombsimon
reviewed
Dec 4, 2024
7phs
commented
Dec 5, 2024
src/tokenizer.rs
Outdated
| .dialect | ||
| .nested_quote_start(quote_start, chars.peekable.clone()) | ||
| { | ||
| chars.next(); // consume the opening quote |
There was a problem hiding this comment.
This code is RedShift specific (nested quotation). The same time tokenisation of quoted identifier is a method of tokeniser and this is a reason of implemented it here.
Let me know if you have a good idea how makes this code more explicit.
iffyio
reviewed
Dec 5, 2024
added 2 commits
December 5, 2024 20:56
bombsimon
reviewed
Dec 6, 2024
iffyio
reviewed
Dec 6, 2024
iffyio
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoted identifiers allow the use of any characters and can start with any character, including digits. For example:
However, the tokenizer cannot parse such types of quoted identifiers in the case of Redshift. This issue is related to the handling of potential identifiers in PartiQL.
This merge request (MR) clarifies the behavior of quoted identifiers in PartiQL and fixes the parsing of quoted identifiers for Redshift.
I added an additional case of a valid JSON path in a specific unit test to ensure that JSON path parsing is not broken.