Skip to content

Add support for PostgreSQL UNLISTEN syntax and Add support for Postgres LOAD extension expr #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

wugeer
Copy link
Contributor

@wugeer wugeer commented Nov 18, 2024

This PR supports two PostgreSQL syntaxes,one is

and the other is

It also introduces the following keywords:

  • UNLISTEN

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wugeer! left a couple comments

@wugeer wugeer requested a review from iffyio November 19, 2024 05:07
@wugeer
Copy link
Contributor Author

wugeer commented Nov 19, 2024

@iffyio Thank you for reviewing the code. I've pushed the changes again. Looking forward to your next review :)

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wugeer!
cc @alamb

@alamb alamb merged commit 73947a5 into apache:main Nov 19, 2024
8 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 19, 2024

Thanks @iffyio and @wugeer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants