support column type definitions in table aliases #1526

lovasoa · 2024-11-15T21:56:02Z

SELECT * FROM some_fun() AS x (a TEXT, b INT)

fixes #1524

```sql SELECT * FROM some_fun() AS x (a TEXT, b INT) ``` fixes apache#1524

src/parser/mod.rs

tests/sqlparser_common.rs

src/ast/query.rs

iffyio

LGTM! cc @alamb

src/ast/query.rs

alamb · 2024-11-18T12:30:32Z

nice!

lovasoa added 2 commits November 15, 2024 22:51

This adds support for

1be060f

```sql SELECT * FROM some_fun() AS x (a TEXT, b INT) ``` fixes apache#1524

fix cargo doc

8494ce8

iffyio reviewed Nov 16, 2024

View reviewed changes

src/parser/mod.rs Outdated Show resolved Hide resolved

src/parser/mod.rs Outdated Show resolved Hide resolved

tests/sqlparser_common.rs Outdated Show resolved Hide resolved

src/ast/query.rs Outdated Show resolved Hide resolved

apply suggestions

9f6f8e3

iffyio approved these changes Nov 17, 2024

View reviewed changes

src/ast/query.rs Outdated Show resolved Hide resolved

fix apache#1526 (comment)

85d8b4f

alamb merged commit f961efc into apache:main Nov 18, 2024
8 checks passed

lovasoa deleted the support_column_definition_list_in_table_alias branch November 18, 2024 14:20

jqnatividad mentioned this pull request Jan 3, 2025

Bump sqlparser to 0.53.0 pola-rs/polars#20546

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support column type definitions in table aliases #1526

support column type definitions in table aliases #1526

lovasoa commented Nov 15, 2024

iffyio left a comment

alamb commented Nov 18, 2024

support column type definitions in table aliases #1526

support column type definitions in table aliases #1526

Conversation

lovasoa commented Nov 15, 2024

iffyio left a comment

Choose a reason for hiding this comment

alamb commented Nov 18, 2024