MsSQL TRY_CONVERT #1477
Merged
MsSQL TRY_CONVERT #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Oct 19, 2024
src/parser/mod.rs
Outdated
| @@ -1023,7 +1023,8 @@ impl<'a> Parser<'a> { | |||
| self.parse_time_functions(ObjectName(vec![w.to_ident()])) | |||
| } | |||
| Keyword::CASE => self.parse_case_expr(), | |||
| Keyword::CONVERT => self.parse_convert_expr(), | |||
| Keyword::CONVERT => self.parse_convert_expr(false), | |||
| Keyword::TRY_CONVERT if dialect_of!(self is MsSqlDialect) => self.parse_convert_expr(true), | |||
There was a problem hiding this comment.
Can we have the guard as a dialect method e.g. self.dialect.supports_try_convert()? We can probably include support for the generic dialect as well
tests/sqlparser_mssql.rs
Outdated
| @@ -495,6 +497,8 @@ fn parse_convert() { | |||
| ParserError::ParserError("Expected: an expression, found: )".to_owned()), | |||
| ms().parse_sql_statements(error_sql).unwrap_err() | |||
| ); | |||
|
|
|||
| ms().verified_expr("TRY_CONVERT(VARCHAR(MAX), 'foo')"); | |||
There was a problem hiding this comment.
with the dialect method we can move this over to common.rs as a generic test over the dialects that support the feature
iffyio
reviewed
Oct 19, 2024
There was a problem hiding this comment.
@yoavcloud can we also add the flag to generic dialect? Other than that LGTM!
iffyio
approved these changes
Oct 19, 2024
alamb
approved these changes
Oct 20, 2024
yoavcloud
force-pushed
the
mssql_try_convert
branch
from
a179a21 to
fa8e9c8
Compare
|
Thanks agian @yoavcloud and @iffyio |
Pull Request Test Coverage Report for Build 11429342019Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to parse the MsSQL TRY_CONVERT function, similar to CONVERT