-
Notifications
You must be signed in to change notification settings - Fork 603
Fix #1469 (SET ROLE regression) #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello ! |
Thanks @iffyio
I changed the code to use maybe_parse, which is indeed much cleaner and resolves both your points. Thanks @iffyio ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
@alamb , the test failure does not seem to be related to the contents of the pr.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for merging, @alamb ! |
this fixes a regression that was introduced with the new SetRole statement