-
Notifications
You must be signed in to change notification settings - Fork 602
Add support of EXPLAIN QUERY PLAN
syntax for SQLite dialect
#1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This closes apache#1455. For the syntax documentation, please refer to: https://sqlite.org/lang_explain.html
Pull Request Test Coverage Report for Build 11227323789Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
cc @iffyio |
src/ast/mod.rs
Outdated
if *query_plan { | ||
write!(f, "QUERY PLAN ")?; | ||
} else { | ||
if *analyze { | ||
write!(f, "ANALYZE ")?; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we skip the else condition if it works just as well to do?
if query_plan {
write!()
}
if analyze {
write!()
}
thinking that would keep this part simpler, even though the parser only accepts one or the other for the same statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iffyio Yes, that makes sense. It's better to keep the fmt simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This closes #1455 and introduces one keyword:
PLAN
.For the syntax documentation, please refer to:
https://sqlite.org/lang_explain.html