Skip to content

Support DROP DATABASE #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Support DROP DATABASE #1443

merged 2 commits into from
Sep 29, 2024

Conversation

linhr
Copy link
Contributor

@linhr linhr commented Sep 25, 2024

This fixes #454.

@@ -893,6 +893,20 @@ fn parse_drop_schema_if_exists() {
}
}

#[test]
fn parse_drop_database_if_exists() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this test case also live in common.rs similar to the other drop test case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @linhr and @iffyio 🙏

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11091437986

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 26 (92.31%) changed or added relevant lines in 3 files are covered.
  • 761 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 89.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 21 23 91.3%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_common.rs 10 89.69%
src/ast/mod.rs 304 82.42%
src/parser/mod.rs 447 93.28%
Totals Coverage Status
Change from base Build 10980785660: -0.04%
Covered Lines: 29807
Relevant Lines: 33373

💛 - Coveralls

@alamb
Copy link
Contributor

alamb commented Sep 29, 2024

🚀

@alamb alamb merged commit 73dc8a3 into apache:main Sep 29, 2024
10 checks passed
@linhr linhr deleted the drop-database branch September 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database ObjectType
4 participants