-
Notifications
You must be signed in to change notification settings - Fork 602
Snowflake: support of views column comment #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake: support of views column comment #1441
Conversation
Pull Request Test Coverage Report for Build 11101253622Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snowflake supports adding comments to fields within a view:
This MR introduces support for this feature.
Additionally, I noticed that the view's comment was not in the correct order—this issue surfaced while testing with a large query from a Snowflake production environment. The comment for the view should appear after the column list. I've included this minor fix in this MR as well. Please let me know if you think it would be better to address this in a separate MR.