Skip to content

Add a test showing how negative constants are parsed #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 10, 2024

I was surprised no test changes were needed when reviewing #1419 so I wanted to add a test showing how -10 is parsed (as a - and a 10)

@coveralls
Copy link

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10799916496

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 89.313%

Totals Coverage Status
Change from base Build 10799657783: 0.006%
Covered Lines: 29184
Relevant Lines: 32676

💛 - Coveralls

@alamb alamb merged commit cb0c511 into apache:main Sep 10, 2024
10 checks passed
@alamb alamb deleted the alamb/value_test branch September 10, 2024 20:19
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants