Skip to content

Add support of DROP|CLEAR|MATERIALIZE PROJECTION syntax for ClickHouse #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Sep 8, 2024

ClickHouse allows to maintain its projection via using alter table with ADD|DROP|CLEAR|MATERIALIZE PROJECTION. For the documentation, please refer to:

[1] https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#drop-projection
[2] https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#clear-projection
[3] https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#materialize-projection

This PR also introduces two keywords:

  • CLEAR
  • MATERIALIZE

ClickHouse allows to maintain its projection via using alter table with
`ADD|DROP|CLEAR|MATERIALIZE PROJECTION`. For the documentation, please
refer to:

[1] https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#drop-projection
[2] https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#clear-projection
[3] https://clickhouse.com/docs/en/sql-reference/statements/alter/projection#materialize-projection

This PR also introduces two keywords:

- CLEAR
- MATERIALIZE
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10758965744

Details

  • 92 of 96 (95.83%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/ddl.rs 25 29 86.21%
Totals Coverage Status
Change from base Build 10739992817: 0.02%
Covered Lines: 29018
Relevant Lines: 32507

💛 - Coveralls

@git-hulk
Copy link
Member Author

git-hulk commented Sep 8, 2024

cc @iffyio

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thanks @git-hulk and @iffyio

@alamb alamb merged commit a7b49b5 into apache:main Sep 10, 2024
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants