minor: Add databricks dialect to dialect_from_str

[milenkovicm]

Databricks dialect is missing in dialect_from_str function

[coveralls]

Pull Request Test Coverage Report for Build 10799617540

Details

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.001%) to 89.307%

---

Totals
Change from base Build 10799563174:	0.001%
Covered Lines:	29166
Relevant Lines:	32658

---

💛 - Coveralls

[Dandandan]

Databricks dialect is missing in dialect_from_str function

Is there anything that you plan implementing for Databricks dialect? I think databricks mostly should be able to use ansidialect.

[milenkovicm]

I'm not sure I'll be able to implement anything in short term, I've tried to use it from datafusion to realise it's not there.

the edge case I've found is CREATE TABLE USING https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-ddl-create-table-using.html

please ignore PR if it should not be expose

[alamb]

I think this is a reasonable change and improvement. Thank you @milenkovicm and @Dandandan

Maybe it would be great to add some tests to avoid new dialects being missed, but we could do that as a follow on PR

[milenkovicm]

also, as a follow up, once sqlparser has been upgraded (in datafusion), error messages have to handle new dialect as well

• https://github.com/apache/datafusion/blob/6e790cf1f363652c3f2ed64286da75a1d5e88cb9/datafusion-cli/src/exec.rs#L218
• https://github.com/apache/datafusion/blob/6e790cf1f363652c3f2ed64286da75a1d5e88cb9/datafusion/core/src/execution/session_state.rs#L491

maybe generic approach should be taken like in https://github.com/apache/datafusion/blob/6e790cf1f363652c3f2ed64286da75a1d5e88cb9/datafusion-cli/src/helper.rs#L75

[alamb]

maybe generic approach should be taken like in https://github.com/apache/datafusion/blob/6e790cf1f363652c3f2ed64286da75a1d5e88cb9/datafusion-cli/src/helper.rs#L75

I generic approach that lists all the dialects programatically makes a lot of sense to me.

[alamb]

I merged this PR up from main and added a small test