Skip to content

Fix Hive table comment should be after table column definitions #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Sep 6, 2024

@git-hulk
Copy link
Member Author

git-hulk commented Sep 6, 2024

cc @iffyio

@coveralls
Copy link

coveralls commented Sep 6, 2024

Pull Request Test Coverage Report for Build 10741575824

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 26 of 27 (96.3%) changed or added relevant lines in 4 files are covered.
  • 1029 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.008%) to 89.246%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/dml.rs 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/dialect/bigquery.rs 1 63.64%
src/dialect/hive.rs 1 83.33%
src/dialect/databricks.rs 1 68.75%
src/ast/value.rs 1 86.96%
src/dialect/ansi.rs 1 83.33%
src/dialect/clickhouse.rs 2 58.33%
src/dialect/mysql.rs 2 90.38%
src/lib.rs 12 12.47%
src/dialect/mod.rs 21 67.91%
tests/sqlparser_bigquery.rs 131 90.32%
Totals Coverage Status
Change from base Build 10723205248: -0.008%
Covered Lines: 28947
Relevant Lines: 32435

💛 - Coveralls

@git-hulk git-hulk requested a review from iffyio September 6, 2024 13:49
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @git-hulk and @iffyio

@alamb alamb merged commit 6ba6068 into apache:main Sep 10, 2024
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HiveDialect doesn't support create table with PARTITIONED BY and CLUSTERED BY clause
4 participants