Add support of parsing CLUSTERED BY clause for Hive #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
commented
Aug 23, 2024
| @@ -236,19 +239,6 @@ impl Display for CreateTable { | |||
| HiveDistributionStyle::PARTITIONED { columns } => { | |||
| write!(f, " PARTITIONED BY ({})", display_comma_separated(columns))?; | |||
| } | |||
| HiveDistributionStyle::CLUSTERED { | |||
There was a problem hiding this comment.
PARTIONED BY and CLUSTERED BYcan appear at the same time, so we cannot use an enum to put them together. I remove CLUSTERED from HiveDistributionStyle here but it won't affect users since we don't support parsing CLUSTERED BY before this PR. cc @iffyio
This PR supports `CLUSTERED BY` clause in CREATE TABLE for Hive dialect, which is used to group data into buckets by CLUSTERED BY columns. For more information, please refer to: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-CreateTable And it also introduces the following keywords: - CLUSTERED - SORTED - BUCKETS
git-hulk
force-pushed
the
feature/clustered-by-for-hive
branch
from
b990684 to
e7ae11e
Compare
Pull Request Test Coverage Report for Build 10538676696Details
💛 - Coveralls |
iffyio
approved these changes
Aug 27, 2024
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports
CLUSTERED BYclause in the CREATE TABLE for Hive dialect, which is used to group data into buckets by CLUSTERED BY columns. For more information, please refer to:https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-CreateTable
It also introduces the following keywords:
This resolves part of issue #1395.