-
Notifications
You must be signed in to change notification settings - Fork 606
allow DateTimeField::Custom
with EXTRACT
in Postgres
#1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 10512598473Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I think this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @samuelcolvin and @iffyio
I'm really not a fan of this
dialect_of!
stuff, it feels like I'm back writing some kind of odd Python. (I've changed this)Follows #1191.
This will allow us to match postgres syntax:
I guess all the unit names and abbreviations allowed by
INTERVAL
which I added in apache/arrow-rs#6211 are allowed, we should be able to useIntervalUnit
in datafusion to process the custom value.