Skip to content

adding support for scale in CEIL and FLOOR functions #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2024
Merged

adding support for scale in CEIL and FLOOR functions #1377

merged 3 commits into from
Aug 14, 2024

Conversation

seve-martinez
Copy link
Contributor

Closes #1376.

alamb
alamb reviewed Aug 13, 2024
View reviewed changes
@coveralls
Copy link

coveralls commented Aug 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10371893226

Details

  • 41 of 47 (87.23%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 89.045%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 6 8 75.0%
src/parser/mod.rs 7 9 77.78%
tests/sqlparser_common.rs 28 30 93.33%
Totals Coverage Status
Change from base Build 10370172981: -0.007%
Covered Lines: 27677
Relevant Lines: 31082
💛 - Coveralls

alamb
alamb reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @seve-martinez

@seve-martinez seve-martinez force-pushed the smartinez/support_ceil_floor_snowflake_syntax branch from 7a1716d to 4648951 Compare August 13, 2024 14:18
@seve-martinez seve-martinez force-pushed the smartinez/support_ceil_floor_snowflake_syntax branch from 3cbf862 to 085bd67 Compare August 13, 2024 14:39
alamb
alamb approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seve-martinez -- this makes sense to me

I plan to wait a few days to see if @iffyio would like a chance to review it as well

iffyio
iffyio approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb alamb merged commit c2f46ae into apache:main Aug 14, 2024
10 checks passed
@alamb
Copy link
Contributor

alamb commented Aug 14, 2024

Thanks again @seve-martinez and @iffyio

ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
@seve-martinez @ayman-sigma
adding support for scale in CEIL and FLOOR functions (apache#1377)
0b1b66a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CEIL and FLOOR do not support comma syntax
4 participants
@seve-martinez @coveralls @alamb @iffyio