minor: Implement common traits for OneOrManyWithParens #1368
Conversation
Pull Request Test Coverage Report for Build 10434835580Details
💛 - Coveralls |
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
…nto deref_one_or_many_with_parens
Sure, it makes sense, so much so that while I was writing it, I realized it wasn't enough for my intended usage 😅 |
src/ast/mod.rs
Outdated
| OneOrManyWithParens::Many(many) => (None, many), | ||
| }; | ||
|
|
||
| one.into_iter().chain(many) |
There was a problem hiding this comment.
This is a bit strange, it could be
vec![one]and just returnVec::into_iter, but it allocates, or- create and implement a new iterator, but it's much more work, and we won't get for free additional iterator traits impls.
Just let me know if other approach is preferable
There was a problem hiding this comment.
create and implement a new iterator, but it's much more work, and we won't get for free additional iterator traits impls.
this is what i would have expected.
Not sure what you mean "won't get for free additional iterator traits impl"
Another potential approach is returning a Boxed iterator
There was a problem hiding this comment.
It wasn't too much work after all 😬
Not sure what you mean "won't get for free additional iterator traits impl"
It's actually just DoubleEndedIterator, I thought there were more
gstvg
changed the title
src/ast/mod.rs
Outdated
| OneOrManyWithParens::Many(many) => (None, many), | ||
| }; | ||
|
|
||
| one.into_iter().chain(many) |
There was a problem hiding this comment.
create and implement a new iterator, but it's much more work, and we won't get for free additional iterator traits impls.
this is what i would have expected.
Not sure what you mean "won't get for free additional iterator traits impl"
Another potential approach is returning a Boxed iterator
| @@ -1004,6 +1005,51 @@ pub enum OneOrManyWithParens<T> { | |||
| Many(Vec<T>), | |||
| } | |||
|
|
|||
| impl<T> Deref for OneOrManyWithParens<T> { | |||
There was a problem hiding this comment.
This is looking good -- I think if we are going to add this code we should also add examples to the documentation f OneOrManyWithParens otherwise it will likely be hard to find
So like
/// # Example: accessing as a slice:
/// ...
/// # Example: iterating
/// ...
…nto deref_one_or_many_with_parens
This allows accessing all inner values without matching