-
Notifications
You must be signed in to change notification settings - Fork 612
Parse SETTINGS clause for ClickHouse table-valued functions #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b93b5f2
to
c48f157
Compare
3e4d49c
to
d6bbe52
Compare
d6bbe52
to
c6b9d6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Jesse-Bakker and @git-hulk and @iffyio
Pull Request Test Coverage Report for Build 10179089478Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
🚀 |
Allows parsing the
executable
table-valued function, for example