Skip to content

Parse SETTINGS clause for ClickHouse table-valued functions #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

Jesse-Bakker
Copy link
Contributor

Allows parsing the executable table-valued function, for example

@Jesse-Bakker Jesse-Bakker force-pushed the table-function-settings branch from b93b5f2 to c48f157 Compare July 29, 2024 07:41
@Jesse-Bakker Jesse-Bakker requested a review from iffyio July 30, 2024 06:53
@Jesse-Bakker Jesse-Bakker force-pushed the table-function-settings branch from 3e4d49c to d6bbe52 Compare July 30, 2024 07:15
@Jesse-Bakker Jesse-Bakker force-pushed the table-function-settings branch from d6bbe52 to c6b9d6a Compare July 30, 2024 07:17
@Jesse-Bakker Jesse-Bakker requested a review from git-hulk July 31, 2024 11:09
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jesse-Bakker and @git-hulk and @iffyio

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10179089478

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 88 of 89 (98.88%) changed or added relevant lines in 3 files are covered.
  • 1229 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.03%) to 89.21%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 44 45 97.78%
Files with Coverage Reduction New Missed Lines %
src/test_utils.rs 1 90.65%
src/ast/query.rs 21 86.08%
src/ast/dml.rs 25 74.09%
tests/sqlparser_bigquery.rs 31 90.18%
src/parser/mod.rs 195 93.33%
tests/sqlparser_postgres.rs 272 87.97%
src/ast/mod.rs 273 81.49%
tests/sqlparser_common.rs 411 89.58%
Totals Coverage Status
Change from base Build 10152006031: 0.03%
Covered Lines: 27399
Relevant Lines: 30713

💛 - Coveralls

@alamb
Copy link
Contributor

alamb commented Aug 1, 2024

🚀

@alamb alamb merged commit d49acc6 into apache:main Aug 1, 2024
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants