Support Map literal syntax for DuckDB and Generic #1344
Conversation
|
Gentle ping @alamb |
|
This is interesting PR. |
|
Sorry -- I am behind on reviews. I triggered the worflow |
src/parser/mod.rs
Outdated
| @@ -1078,6 +1078,9 @@ impl<'a> Parser<'a> { | |||
| let expr = self.parse_subexpr(Self::PLUS_MINUS_PREC)?; | |||
| Ok(Expr::Prior(Box::new(expr))) | |||
| } | |||
| Keyword::MAP if self.peek_token() == Token::LBrace => { | |||
There was a problem hiding this comment.
Should this also check dialect.support_map_literal_syntax()?
There was a problem hiding this comment.
Sounds great. Thanks
Pull Request Test Coverage Report for Build 10027832349Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
src/ast/mod.rs
Outdated
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))] | ||
| pub struct Map { | ||
| pub fields: Vec<MapField>, |
There was a problem hiding this comment.
| pub fields: Vec<MapField>, | |
| pub entries: Vec<MapEntry>, |
we can probably use entry since field could be confused for the key part of the map?
There was a problem hiding this comment.
Thanks @iffyio. Sounds great!
|
Thank you @goldmedal and @iffyio I plan a release early this upcoming week for another reason, so this should be available shortly |
Description
I added Map syntax of DuckDB for
DuckDBandGenericdialects.For example:
It will also be used by apache/datafusion#11434 for creating the scalar map.