Skip to content

Snowflake: support position with normal function call syntax #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented Jul 14, 2024

On Snowflake, the special IN syntax is optional: https://docs.snowflake.com/en/sql-reference/functions/position. This PR updates the parser to accept this.

@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 10133397097

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 89.222%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 12 13 92.31%
Files with Coverage Reduction New Missed Lines %
src/ast/query.rs 1 85.93%
src/parser/mod.rs 1 93.32%
tests/sqlparser_common.rs 4 89.6%
src/lib.rs 7 12.64%
Totals Coverage Status
Change from base Build 10063291795: -0.03%
Covered Lines: 27203
Relevant Lines: 30489

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comments from @iffyio and @git-hulk are good. Once those get done I think this PR is good to go.

Thanks everyone

@jmhain
Copy link
Contributor Author

jmhain commented Jul 28, 2024

@iffyio @alamb Addressed the comments. Sorry for the delay in getting back to this!

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@alamb
Copy link
Contributor

alamb commented Jul 29, 2024

Thank you @jmhain @iffyio and @git-hulk

@alamb alamb merged commit c3ba2f3 into apache:main Jul 29, 2024
10 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants