Skip to content

Support PREWHERE condition for ClickHouse dialect #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2024
Merged

Support PREWHERE condition for ClickHouse dialect #1328

merged 3 commits into from
Jul 7, 2024

Conversation

git-hulk
Copy link
Member

For ClickHouse PREWHERE clause, please refer to:

https://clickhouse.com/docs/en/sql-reference/statements/select/prewhere

@coveralls
Copy link

coveralls commented Jun 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9732699617

Details

  • 60 of 60 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.123%
Totals Coverage Status
Change from base Build 9731662350: 0.02%
Covered Lines: 26506
Relevant Lines: 29741
💛 - Coveralls

iffyio
iffyio approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple minor edits to cover generic in the test case, otherwise LGTM!
cc @alamb

@git-hulk
Copy link
Member Author

git-hulk commented Jul 5, 2024

@iffyio Fixed, thanks!

@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9806936881

Details

  • 60 of 60 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.123%
Totals Coverage Status
Change from base Build 9731662350: 0.02%
Covered Lines: 26506
Relevant Lines: 29741
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9827003675

Details

  • 60 of 60 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.161%
Totals Coverage Status
Change from base Build 9826853711: 0.02%
Covered Lines: 26571
Relevant Lines: 29801
💛 - Coveralls

@alamb alamb changed the title Add the support of PREWHERE condition for ClickHouse dialect Support PREWHERE condition for ClickHouse dialect Jul 7, 2024
alamb
alamb approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @git-hulk and @iffyio

@alamb alamb merged commit 0884dd9 into apache:main Jul 7, 2024
10 checks passed
@Jesse-Bakker Jesse-Bakker mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@git-hulk @coveralls @alamb @iffyio