Improve error messages with additional colons #1319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1259.
Added colons at the end of
Expected
andColumn
in ParserErrors.Tests are also updated and they passed.
I do think this creates another "issue":
Currently, a lot of errors read nice without the colon after
Expected
:"Expected an expression, found: ... "
and others would not read nice:
"Expected (, found: ..."
But with this change, we would flip these experiences:
"Expected: an expression, found: ..." and "Expected (, found: ..."
I do think we should keep the colons, but change the error messages, this is a bit much more work, but if asked i can do it.