-
Notifications
You must be signed in to change notification settings - Fork 603
Postgres: support for OWNER TO
clause
#1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alamb
merged 15 commits into
apache:main
from
gainings:postgres-add-alter-table-owner-to
Jul 9, 2024
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
af560ee
Add keyword for postgres
gainings c351eb8
Add OwnerTo ddl ast
gainings e4d1e95
Add owner to parser in alter talbe operation
gainings 1d5f01d
Add postgres test for owner to
gainings c56120e
Parse OWNER TO clause only for Postgresql
gainings 5c21442
Support CURRENT_ROLE, CURRENT_USER, SESSION_USER Functions for OwnerT…
gainings 4d06a61
Fix expected error message for OwnerTo
gainings 52c162d
Fix postgres test to support CURRENT_USER, CURRENT_ROLE, SESSION_USER
gainings 6076c2d
Apply cargo fmt
gainings a3a4996
Add link
alamb 25d6a40
Support generic dialect
alamb 0ff17d7
Use explicit variants
alamb 4180911
Merge remote-tracking branch 'origin/main' into postgres-add-alter-ta…
alamb 210c5c3
Merge remote-tracking branch 'origin/main' into postgres-add-alter-ta…
alamb 4340c65
Update for latest error messages
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -527,6 +527,7 @@ define_keywords!( | |
OVERLAY, | ||
OVERWRITE, | ||
OWNED, | ||
OWNER, | ||
PARALLEL, | ||
PARAMETER, | ||
PARQUET, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure the error message had some additional context was the only thing that I found awkward. Otherwise I think @iffyio 's suggestions made the code easier to understand and easier to use overall