Skip to content

Add a changelog #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

Add a changelog #129

merged 1 commit into from
Jul 8, 2019

Conversation

nickolay
Copy link
Contributor

@nickolay nickolay commented Jul 6, 2019

Given that people are starting to use this crate, we should probably keep a change log to communicate the breaking changes we make.

@nickolay nickolay requested a review from benesch July 6, 2019 00:51
@coveralls
Copy link

coveralls commented Jul 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 406

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.549%
Totals Coverage Status
Change from base Build 405: 0.0%
Covered Lines: 4335
Relevant Lines: 4684
💛 - Coveralls

benesch
benesch approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Also, wow, putting together the historical list of changes looks like it required a lot of work.

@nickolay nickolay merged commit 275e6b1 into apache:master Jul 8, 2019
@nickolay nickolay deleted the pr/changelog branch July 8, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickolay @coveralls @benesch