Skip to content

Support array indexing for duckdb #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2024
Merged

Support array indexing for duckdb #1265

merged 3 commits into from
May 9, 2024

Conversation

JichaoS
Copy link
Contributor

@JichaoS JichaoS commented May 7, 2024

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8993828008

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 89.215%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_duckdb.rs 15 16 93.75%
Totals Coverage Status
Change from base Build 8989250736: 0.003%
Covered Lines: 24443
Relevant Lines: 27398

💛 - Coveralls

Copy link
Contributor

@jmhain jmhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JichaoS and @jmhain

@alamb alamb merged commit e3692f4 into apache:main May 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants