Skip to content

Databricks: support SELECT * EXCEPT #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

Databricks: support SELECT * EXCEPT #1261

merged 1 commit into from
May 13, 2024

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented May 6, 2024

No description provided.

@jmhain jmhain force-pushed the databricks_except branch from 03d44ed to fddc88d Compare May 6, 2024 00:36
@coveralls
Copy link

coveralls commented May 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9046803716

Details

  • 26 of 34 (76.47%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 89.495%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/bigquery.rs 1 2 50.0%
src/dialect/clickhouse.rs 1 2 50.0%
src/dialect/databricks.rs 1 2 50.0%
src/dialect/generic.rs 1 2 50.0%
src/dialect/mod.rs 1 2 50.0%
tests/sqlparser_common.rs 20 23 86.96%
Totals Coverage Status
Change from base Build 9045941824: -0.01%
Covered Lines: 24875
Relevant Lines: 27795
💛 - Coveralls

iffyio
iffyio approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

alamb
alamb approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmhain and @iffyio

@alamb
Copy link
Contributor

alamb commented May 11, 2024

This PR seems to have conflicts but once those are resolved I'll merge it in

@jmhain jmhain force-pushed the databricks_except branch from fddc88d to 1c5e479 Compare May 11, 2024 22:20
@jmhain
Copy link
Contributor Author

jmhain commented May 11, 2024

@alamb conflicts resolved, thank you!

@alamb alamb merged commit 5ed13b5 into apache:main May 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmhain @coveralls @alamb @iffyio