Extend pivot operator support #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8897486318Details
💛 - Coveralls |
jmhain
reviewed
Apr 29, 2024
| #[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)] | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))] | ||
| pub struct ExprWithAlias { |
There was a problem hiding this comment.
+1 for this type - this could replace Measure from MATCH_RECOGNIZE and probably lots of other similar one-off types
|
looks good to me! cc @alamb |
|
🤔 github says this PR has conflicts that must be resolved prior to merging
|
Extends the parser with support for: - Multiple aggregate function calls - Aliased aggregation function calls - Aliased pivot values - also allowing arbitrary expressions as values https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#pivot_operator
iffyio
force-pushed
the
extend-pivot-operator
branch
from
46bf2d7 to
8dfe4f5
Compare
|
Thanks again |
JichaoS
pushed a commit
to luabase/sqlparser-rs
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the parser with support for:
https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#pivot_operator