-
Notifications
You must be signed in to change notification settings - Fork 605
feat: implement select * ilike for snowflake #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2214f5f
to
f480fda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
f480fda
to
29882fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HiranmayaGundu and @iffyio for the review 🙏
|
||
#[test] | ||
fn test_select_wildcard_with_ilike_replace() { | ||
let res = snowflake().parse_sql_statements(r#"SELECT * ILIKE '%id%' EXCLUDE col FROM tbl"#); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 for the negative test case
Pull Request Test Coverage Report for Build 8768330043Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Implements
SELECT * ILIKE
for Snowflake. This is the relevant SQL documentation: https://docs.snowflake.com/en/sql-reference/sql/select